Ticket #257 (new defect)

Opened 14 months ago

Last modified 14 months ago

Compilation fails with giflib 4.2.1

Reported by: AppleBloom Owned by:
Priority: normal Milestone:
Component: Video Decoder Version: devel
Severity: minor Keywords:
Cc: Platform: All

Description

When compiling with gif decoding support (--enable-gif), the compilation fails with giflib 4.2.1. Here's the relevant output:

libmpdemux/demux_gif.o: In function `demux_close_gif':
demux_gif.c:(.text+0x39): undefined reference to `PrintGifError?'
libmpdemux/demux_gif.o: In function `demux_open_gif':
demux_gif.c:(.text+0x293): undefined reference to `PrintGifError?'
libmpdemux/demux_gif.o: In function `demux_gif_fill_buffer':
demux_gif.c:(.text+0x95b): undefined reference to `PrintGifError?'
demux_gif.c:(.text+0xb1a): undefined reference to `PrintGifError?'

The issue is becayse there were some small changes in version 4.2 of giflib. Most notably, the PrintGifError? function was removed, and two other functions were put in place.

I managed to fix the issue by adding code in demux_gif.c to use the new GifErrorString? to implement PrintGifError? (when giflib's version is 4.2 or above). I'm attaching my patch.

Operating system is ArchLinux? x86-64 and the affected version is v2.0-726-g6c87a98, which is the latest commit on git currently.

Attachments

giflib_420_fix.patch Download (475 bytes) - added by AppleBloom 14 months ago.
Patch that fixes compilation error with giflib>=4.2.0.
giflib_420_fix.2.patch Download (497 bytes) - added by AppleBloom 14 months ago.
Patch that fixes compilation error with giflib>=4.2.0.

Change History

Changed 14 months ago by AppleBloom

Patch that fixes compilation error with giflib>=4.2.0.

Changed 14 months ago by AppleBloom

Patch that fixes compilation error with giflib>=4.2.0.

comment:1 Changed 14 months ago by AppleBloom

I uploaded a second version of the patch which works for all giflib versions above 4.2.

Note: See TracTickets for help on using tickets.